Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): polish assets screen loader #4613

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

evavirseda
Copy link
Contributor

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

fixes #4408

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@evavirseda evavirseda requested a review from a team as a code owner December 24, 2024 09:45
@iota-ci iota-ci added the tooling Issues related to the Tooling team label Dec 24, 2024
@evavirseda evavirseda self-assigned this Dec 24, 2024
@evavirseda evavirseda added the wallet Issues related to the IOTA Wallet label Dec 24, 2024
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, meant to approve 🙏🏼

Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are conflicts 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polish assets screen loader
4 participants