Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(wallet, explorer, dashboard): change default export for components #4617

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

refactor(wallet, explorer, dashboard): change default export for components #4617

wants to merge 6 commits into from

Conversation

panteleymonchuk
Copy link
Contributor

Links to any relevant issues

Closes #4375

Type of change

  • Enhancement (a non-breaking change which adds functionality)

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@panteleymonchuk panteleymonchuk added tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet explorer Issues related to the Explorer wallet-dashboard Issues related to the Wallet Dashboard dApp labels Dec 24, 2024
@panteleymonchuk panteleymonchuk requested a review from a team as a code owner December 24, 2024 12:31
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 8cf12c3

✅ Preview: https://apps-backend-gpww5odp7-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 8cf12c3

✅ Preview: https://apps-ui-iijriwkil-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 8cf12c3

✅ Preview: https://rebased-explorer-dak0agztx-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 02952d4

✅ Preview: https://apps-ui-pesrqf21z-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 02952d4

✅ Preview: https://rebased-explorer-medsoaabn-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 02952d4

✅ Preview: https://apps-backend-7qjnfdise-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 02952d4

✅ Preview: https://wallet-dashboard-42cpkwr6j-iota1.vercel.app

evavirseda
evavirseda requested changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@evavirseda evavirseda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, these files need to be updated too:
apps/wallet/src/ui/app/helpers/index.ts
apps/wallet/src/ui/app/hooks/index.ts
🙏 🙏

apps/explorer/src/components/header/Header.tsx Outdated Show resolved Hide resolved
apps/explorer/src/components/layout/PageLayout.tsx Outdated Show resolved Hide resolved
apps/explorer/src/components/ui/image/Image.tsx Outdated Show resolved Hide resolved
apps/explorer/src/components/ui/image/Image.tsx Outdated Show resolved Hide resolved
apps/explorer/src/pages/object-result/ObjectResult.tsx Outdated Show resolved Hide resolved
apps/wallet/src/ui/app/index.tsx Outdated Show resolved Hide resolved
apps/wallet/src/ui/app/pages/home/index.tsx Outdated Show resolved Hide resolved
apps/wallet/src/ui/app/pages/home/tokens/TokensDetails.tsx Outdated Show resolved Hide resolved
apps/wallet/src/ui/app/pages/home/tokens/index.tsx Outdated Show resolved Hide resolved
apps/wallet/src/ui/index.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 1ec6361

✅ Preview: https://apps-ui-8xtzxn91h-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 1ec6361

✅ Preview: https://apps-backend-egikau3co-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 1ec6361

✅ Preview: https://rebased-explorer-m22zfoilm-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 1ec6361

✅ Preview: https://wallet-dashboard-cta72f8jz-iota1.vercel.app

@panteleymonchuk
Merge remote-tracking branch 'origin/develop' into tooling/cleanup-de…
b201c84 
…fault-exports

# Conflicts:
#	apps/wallet-dashboard/components/Dialogs/Staking/views/EnterAmountView.tsx
#	apps/wallet-dashboard/components/Dialogs/Staking/views/EnterTimelockedAmountView.tsx
#	apps/wallet-dashboard/components/Notifications/Notifications.tsx
#	apps/wallet-dashboard/components/index.ts
@github-actions github-actions bot added the apps-ui-kit Issues related to the Apps UI Kit label Dec 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b201c84

✅ Preview: https://apps-ui-flera1qgg-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b201c84

✅ Preview: https://apps-backend-rjtib7xra-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b201c84

✅ Preview: https://rebased-explorer-4sot853d4-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: b201c84

✅ Preview: https://wallet-dashboard-fouf02j7r-iota1.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evavirseda evavirseda evavirseda approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
apps-ui-kit Issues related to the Apps UI Kit explorer Issues related to the Explorer tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup default exports for any component files
2 participants
@panteleymonchuk @evavirseda