Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(iota-transactional-test-runner): document
run-graphql
syntax #4699base: sc-platform/transactional-tests-syntax
Are you sure you want to change the base?
refactor(iota-transactional-test-runner): document
run-graphql
syntax #4699Changes from 3 commits
77f6d88
a1885f8
c5f9cdc
a18a88c
2aeee5f
341916b
9852d2c
de05b7c
0cde723
fe77000
701df98
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the transaction index? I know it captures the order of creation within the test, but I don't recall if it is sequence number of the command that included the transaction (e.g.
init
) or the absolute sequence number of the transaction. Could elaborate/disambiguate?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, it's the task index, therefore it does not necessarily align with the absolute sequence number of the transaction. When the
IotaTestAdapter
gets initialized, we set thenext_fake
to (0,0).For each objectID we create in the same task, we use the very same task index:
the
next_fake
is only ever increased when we switch to the next task:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactored with fe77000