Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet/wallet-dashboard): show fiat balance #4747

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

feat(wallet/wallet-dashboard): show fiat balance #4747

wants to merge 19 commits into from

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Jan 10, 2025 •
edited
Loading

Description of change

Fixes #3680 and fixes #3679

⚠️ Depends on #4764

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@VmMad VmMad requested a review from a team as a code owner January 10, 2025 12:30
@VmMad VmMad added tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp labels Jan 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c4d3a64

✅ Preview: https://apps-backend-2aw5uxj6y-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c4d3a64

✅ Preview: https://rebased-explorer-n8xu45r8l-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c4d3a64

✅ Preview: https://wallet-dashboard-3tf4oe3nh-iota1.vercel.app

cpl121
cpl121 requested changes Jan 13, 2025
View reviewed changes
apps/core/src/hooks/useTotalFiatBalance.ts Outdated Show resolved Hide resolved
apps/core/src/hooks/useTotalFiatBalance.ts Outdated Show resolved Hide resolved
apps/core/src/hooks/useTotalFiatBalance.ts Outdated Show resolved Hide resolved
apps/core/src/hooks/useTotalFiatBalance.ts Outdated Show resolved Hide resolved
@VmMad VmMad requested a review from cpl121 January 13, 2025 09:29
@github-actions github-actions bot added the apps-backend Issues related to the Apps Backend label Jan 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 65b6f6c

✅ Preview: https://rebased-explorer-f3yxxodys-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 65b6f6c

✅ Preview: https://wallet-dashboard-d095puqi1-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 31d97cb

✅ Preview: https://rebased-explorer-82ya1wlzu-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 31d97cb

✅ Preview: https://wallet-dashboard-nd2q38edh-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 7e8290e

✅ Preview: https://apps-backend-noeb948ie-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 7e8290e

✅ Preview: https://rebased-explorer-k27820khn-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 7e8290e

✅ Preview: https://wallet-dashboard-gmw1oy2qz-iota1.vercel.app

cpl121
cpl121 requested changes Jan 13, 2025
View reviewed changes
apps/core/src/hooks/useTokenPrice.ts Outdated Show resolved Hide resolved
apps/core/src/hooks/useTotalFiatBalance.ts Outdated
const totalBalanceInUsd = Number(coinBalance) * Number(coinPrice);
return Number(totalBalanceInUsd).toLocaleString('en', {
style: 'currency',
currency: 'USD',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could also be a constant, right?

Copy link
Member Author

@VmMad VmMad Jan 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so could the locale, and the style, but maybe a format function is better, no?

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a2028d4

✅ Preview: https://apps-backend-4k1rf96wm-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a2028d4

✅ Preview: https://rebased-explorer-16gxk5ecp-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: a2028d4

✅ Preview: https://wallet-dashboard-473lygs6r-iota1.vercel.app

@github-actions github-actions bot added wallet Issues related to the IOTA Wallet explorer Issues related to the Explorer labels Jan 13, 2025
@VmMad VmMad changed the base branch from develop to tooling-explorer/add-burned-minted-token-amounts-to-ended-epoch January 15, 2025 10:29
@VmMad
Merge branch 'tooling-explorer/add-burned-minted-token-amounts-to-end…
d2d2772 
…ed-epoch' into tooling-dashboard/hook-fiat-price
@vercel Vercel
Copy link

vercel bot commented Jan 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 3:27pm
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 3:27pm
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 3:27pm
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 3:27pm

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d2d2772

✅ Preview: https://rebased-explorer-3mr0ij5wq-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d2d2772

✅ Preview: https://wallet-dashboard-ow02xo2er-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 7cdcf89

✅ Preview: https://rebased-explorer-7d9uh3dle-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 7cdcf89

✅ Preview: https://wallet-dashboard-bb0j1diby-iota1.vercel.app

@VmMad VmMad requested a review from evavirseda January 15, 2025 12:03
Base automatically changed from tooling-explorer/add-burned-minted-token-amounts-to-ended-epoch to develop January 15, 2025 15:20
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 5dad3ee

✅ Preview: https://rebased-explorer-hfcqfa78e-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 5dad3ee

✅ Preview: https://wallet-dashboard-cwhmtw399-iota1.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpl121 cpl121 Awaiting requested review from cpl121

@evavirseda evavirseda Awaiting requested review from evavirseda

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
apps-backend Issues related to the Apps Backend explorer Issues related to the Explorer tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename coingecko fiat pricing api Hook fiat pricing to wallet dashboard Hook fiat pricing to wallet
3 participants
@VmMad @evavirseda @cpl121