Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet-dashboard): add React Query Devtools and invalidate migration transaction queries #4782

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat(wallet-dashboard): add React Query Devtools and invalidate migration transaction queries #4782

wants to merge 2 commits into from
+27 −18

Conversation

panteleymonchuk
Copy link
Contributor

Links to any relevant issues

Fixes #4720

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@panteleymonchuk panteleymonchuk added tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp labels Jan 14, 2025
@panteleymonchuk panteleymonchuk requested a review from a team as a code owner January 14, 2025 17:28
@vercel Vercel
Copy link

vercel bot commented Jan 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apps-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 0:48am
rebased-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 0:48am
wallet-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 0:48am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 0:48am

@panteleymonchuk panteleymonchuk marked this pull request as draft January 14, 2025 17:28
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2707389

✅ Preview: https://wallet-dashboard-il3yspp7p-iota1.vercel.app

@panteleymonchuk panteleymonchuk marked this pull request as ready for review January 15, 2025 12:39
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 2707389

✅ Preview: https://wallet-dashboard-8ry1fcmcp-iota1.vercel.app

cpl121
cpl121 requested changes Jan 16, 2025
View reviewed changes
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a flash when closing the dialog
https://www.awesomescreenshot.com/video/35592990?key=141643b227282ac11a3ca5b32ec29c25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpl121 cpl121 cpl121 requested changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update migration-transaction key for consecutive migrations
4 participants
@panteleymonchuk @begonaalvarezd @cpl121 @marc2332