-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(genesis-geremony): fix examine-genesis-checkpoint #4829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
iota-ci
added
the
sc-platform
Issues related to the Smart Contract Platform group.
label
Jan 16, 2025
nonast
force-pushed
the
vm-language/examine-genesis-checkpoint
branch
from
January 17, 2025 07:00
7d44af5
to
aa286a5
Compare
miker83z
requested review from
a team,
kodemartin and
miker83z
as code owners
January 20, 2025 16:03
@nonast please add in the description the steps on how to reproduce the environment to execute the command: $ mkdir genesis && cd genesis
$ cargo run --release --bin iota genesis-ceremony init
$ cargo run --release --bin iota-genesis-builder -- --disable-global-snapshot-verification iota --snapshot-path ../../latest-full_snapshot.bin --target-network alphanet-test
$ ../target/release/iota validator make-validator-info validator1 validator1 https://www.iota.org/favicon.png https://www.iota.org /ip4/127.0.0.1 1000
$ ../target/release/iota genesis-ceremony add-validator \
--name validator1 \
--authority-key-file authority.key \
--protocol-key-file protocol.key \
--account-key-file account.key \
--network-key-file network.key \
--network-address /ip4/127.0.0.1/tcp/38189/http \
--p2p-address /ip4/127.0.0.1/udp/34523 \
--primary-address /ip4/127.0.0.1/udp/38603 \
--description validator1 \
--image-url https://www.iota.org/favicon.png \
--project-url https://www.iota.org
$ ADDRESS=$(sed -n 4p committee/validator1 | cut -d ":" -f2- | tr -d ' "')
$ echo "delegator,validator,amount-nanos-to-stake,amount-nanos-to-pay-gas" >> delegations.csv
$ echo "0x4f72f788cdf4bb478cf9809e878e6163d5b351c82c11f1ea28750430752e7892,${ADDRESS},1500000000000000,1500000000000000" >> delegations.csv
$ ../target/release/iota genesis-ceremony init-delegations --delegations-path delegations.csv
$ ../target/release/iota genesis-ceremony build-unsigned-checkpoint --local-migration-snapshots stardust_object_snapshot.bin
$ ../target/release/iota genesis-ceremony examine-genesis-checkpoint |
6 tasks
valeriyr
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
miker83z
approved these changes
Jan 27, 2025
Alex6323
reviewed
Jan 28, 2025
thibault-martinez
approved these changes
Jan 28, 2025
Alex6323
reviewed
Jan 28, 2025
Alex6323
reviewed
Jan 28, 2025
Alex6323
reviewed
Jan 28, 2025
Alex6323
reviewed
Jan 28, 2025
Alex6323
reviewed
Jan 28, 2025
miker83z
force-pushed
the
vm-language/examine-genesis-checkpoint
branch
from
January 28, 2025 11:12
65379ca
to
13df074
Compare
Alex6323
approved these changes
Jan 28, 2025
This was referenced Jan 28, 2025
lzpap
pushed a commit
that referenced
this pull request
Jan 29, 2025
* fix: examine genesis checkpoint * chore: clippy and fmt * refactor: is_maybe to try_from * chore: remove unused functions * refactor: remove unwrap from func * chore: remove unused to_bytes funcs * chore: cargo fmt * chore: correct spelling * fix(genesis-inspector): consider TimelockedStakedIota as a stake * refactor(genesis-inspector): get migration objects as iterator * add timelock balance assert * fixes coming from different review comments --------- Co-authored-by: Mirko Zichichi <[email protected]> Co-authored-by: miker83z <[email protected]>
This was referenced Jan 29, 2025
lzpap
added a commit
that referenced
this pull request
Jan 29, 2025
* fix: examine genesis checkpoint * chore: clippy and fmt * refactor: is_maybe to try_from * chore: remove unused functions * refactor: remove unwrap from func * chore: remove unused to_bytes funcs * chore: cargo fmt * chore: correct spelling * fix(genesis-inspector): consider TimelockedStakedIota as a stake * refactor(genesis-inspector): get migration objects as iterator * add timelock balance assert * fixes coming from different review comments --------- Co-authored-by: Nonast <[email protected]> Co-authored-by: Mirko Zichichi <[email protected]> Co-authored-by: miker83z <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sc-platform
Issues related to the Smart Contract Platform group.
vm-language
Issues related to the VM & Language Team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This (draft) PR fixes the
examine-genesis-checkpoint
command of the genesis ceremony. Due to the migrated objects, the genesis inspector did not function correctly anymore, as not all objects exist in the first genesis state. These migrated objects are created in the following transactions. The genesis inspector was not built to take these extra migrated objects into account. In this PR, the migrated objects are also included in the list of objects that is used to count the total supply. The object inspector of this function now also functions as expected.Will rebase on develop
Links to any relevant issues
fixes #4528
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Ran a genesis ceremony up to the point where
examine-genesis-checkpoint
is called:Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.