Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet-dashboard): update migration portfolio to include shared objects #4974

Merged
merged 22 commits into from
Jan 29, 2025
Merged

feat(wallet-dashboard): update migration portfolio to include shared objects #4974

merged 22 commits into from
Jan 29, 2025

Conversation

panteleymonchuk
Copy link
Contributor

Links to any relevant issues

Closes #4805

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@panteleymonchuk panteleymonchuk added tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp labels Jan 22, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apps-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 0:40am
apps-ui-kit ✅ Ready (Inspect) Visit Preview Jan 29, 2025 0:40am
rebased-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 0:40am
wallet-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 0:40am

@github-actions github-actions bot added the ts-sdk Issues related to the TS SDK label Jan 22, 2025
@panteleymonchuk panteleymonchuk marked this pull request as ready for review January 23, 2025 14:04
@panteleymonchuk panteleymonchuk requested a review from a team as a code owner January 23, 2025 14:04
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025 •
edited
Loading

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset in the root of the IOTA repo, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

cpl121
cpl121 requested changes Jan 24, 2025
View reviewed changes
apps/core/src/api/StardustIndexerClient.ts Outdated Show resolved Hide resolved
apps/wallet-dashboard/lib/utils/migration/groupStardustObjectsByMigrationStatus.ts Outdated Show resolved Hide resolved
apps/wallet-dashboard/lib/utils/timelock.ts Outdated Show resolved Hide resolved
apps/core/src/utils/migration/mapStardustIndexerOutputs.ts Outdated Show resolved Hide resolved
apps/core/src/hooks/useGetAllOwnedObjects.ts Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – rebased-explorer January 28, 2025 13:00 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-backend January 28, 2025 13:00 Inactive
cpl121
cpl121 requested changes Jan 28, 2025
View reviewed changes
sdk/typescript/src/client/network.ts Show resolved Hide resolved
apps/core/src/constants/migration.constants.ts Outdated Show resolved Hide resolved
begonaalvarezd
begonaalvarezd requested changes Jan 28, 2025
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would also be missing adding invalidations to the stardust-indexer-outputs query key in apps/wallet-dashboard/app/(protected)/migrations/page.tsx

apps/wallet-dashboard/hooks/useGetAllStardustSharedObjects.ts Outdated Show resolved Hide resolved
apps/wallet-dashboard/hooks/useGetStardustMigratableObjects.ts Outdated Show resolved Hide resolved
apps/wallet-dashboard/hooks/useGetStardustMigratableObjects.ts Outdated Show resolved Hide resolved
apps/wallet-dashboard/hooks/useGetStardustMigratableObjects.ts Outdated Show resolved Hide resolved
sdk/typescript/src/client/network.ts Show resolved Hide resolved
apps/wallet-dashboard/hooks/useGetAllStardustSharedObjects.ts Outdated Show resolved Hide resolved
@begonaalvarezd begonaalvarezd changed the title feat(dashboard): update migration portfolio to include shared objects feat(wallet-dashboard): update migration portfolio to include shared objects Jan 28, 2025
@panteleymonchuk
refactor(core, dashboard): update Stardust package ID format, improve…
3d50207 
… metadata handling in hooks, rename variables.
brancoder
brancoder requested changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts 🙏

brancoder
brancoder approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@brancoder brancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@begonaalvarezd begonaalvarezd merged commit 9d988ec into develop Jan 29, 2025
34 checks passed
@begonaalvarezd begonaalvarezd deleted the tooling-wallet/add-objects-from-indexer branch January 29, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpl121 cpl121 cpl121 approved these changes

@brancoder brancoder brancoder approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@marc2332 marc2332 Awaiting requested review from marc2332

Assignees
No one assigned
Labels
tooling Issues related to the Tooling team ts-sdk Issues related to the TS SDK wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update migration portfolio to include shared objects
5 participants
@panteleymonchuk @begonaalvarezd @marc2332 @brancoder @cpl121