feat(iota): return String from PTB::execute() #5045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
iota-ci
added
dev-tools
| } | ||
| transaction_response.to_string() | ||
| }; | ||
| println!("{result_string}"); |
There was a problem hiding this comment.
I think it would be useful to have a function that creates the string without printing it, more flexible
There was a problem hiding this comment.
I tried this, but then I don't see a way to render the output in special ways like the help output does currently with some words for example fat and with underline
There was a problem hiding this comment.
Are you saying we are losing this information when converted to a string?
There was a problem hiding this comment.
Yes, unless we return StyledStr, but that seems to be more annoying to work with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Return a String from PTB::execute so one can use it for tests
Links to any relevant issues
Fixes #5032
Type of change
How the change has been tested
Modified test and running ptb commands like
cargo run client ptb --helpto verify that they still print the same as before and nothing duplicated