feat: build docker images on platform-specific runners instead of QEMU #5048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsporn
requested review from
msarcev,
thibault-martinez,
DaughterOfMars and
Dr-Electron
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
alexsporn
force-pushed
the
core-protocol/docker-arm-split
branch
from
8cce023 to
af0b60e
Compare
alexsporn
force-pushed
the
core-protocol/docker-arm-split
branch
from
af0b60e to
ef70952
Compare
alexsporn
force-pushed
the
core-protocol/docker-arm-split
branch
from
ef70952 to
9b0498c
Compare
alexsporn
force-pushed
the
core-protocol/docker-arm-split
branch
7 times, most recently
from
7d484ac to
e68371f
Compare
alexsporn
force-pushed
the
core-protocol/docker-arm-split
branch
from
46f1dc4 to
be841d7
Compare
alexsporn
force-pushed
the
core-protocol/docker-arm-split
branch
from
be841d7 to
53b808e
Compare
…platform-specific runners
alexsporn
force-pushed
the
core-protocol/docker-arm-split
branch
from
53b808e to
0b17f9a
Compare
alexsporn
changed the title
|
|
||
| # Check iota_node: true if the input is set to true and the event is workflow_dispatch, | ||
| # or if the event is a release (in which case the job should run regardless of the input). | ||
| if [ "${{ github.event_name == 'workflow_dispatch' && github.event.inputs.iota_node == 'true' || github.event_name == 'release' }}" == "true" ]; then |
There was a problem hiding this comment.
Just curious, do we actually need the final == "true"? Isn't it already a boolean?
| exit 1 | ||
| fi | ||
|
|
||
| echo "images=[$(printf '"%s",' "${images_array[@]}" | sed 's/,$//')]" >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
I'm assuming this makes it into a JSON compatible square-bracket array?
|
|
||
| - name: Build and push Docker image for iota-node | ||
| - name: Build and push by digest |
There was a problem hiding this comment.
What does "by digest" mean here?
thibault-martinez
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Split the docker workflow into separate jobs to be able to build on platform-specific runners
Fixes #5046