Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(*): Update external rust SDK types #5195

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

chore(*): Update external rust SDK types #5195

wants to merge 8 commits into from

Conversation

DaughterOfMars
Copy link
Contributor

@DaughterOfMars DaughterOfMars commented Feb 4, 2025 •
edited
Loading

Description of change

Updates the external rust SDK types lib to use iotaledger/iota-rust-sdk#25.

NOTE: This currently is pointing to the PR commit. This will have to be updated once it is merged in that repo.

@DaughterOfMars DaughterOfMars requested review from a team as code owners February 4, 2025 14:30
@vercel Vercel
Copy link

vercel bot commented Feb 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 6:25pm
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 6:25pm
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 6:25pm
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 6:25pm

@iota-ci iota-ci added dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group. labels Feb 4, 2025
@muXxer
Copy link
Contributor

muXxer commented Feb 4, 2025

What is the reasoning to remove all the Versions from the structs?

@DaughterOfMars
Copy link
Contributor Author

What is the reasoning to remove all the Versions from the structs?

IIRC they were removed in the upstream changes

@DaughterOfMars DaughterOfMars requested a review from a team as a code owner February 4, 2025 19:42
muXxer
muXxer requested changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@muXxer muXxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes related to any version number removal.

ConsensusCommitPrologueV1 also exists on current upstream.
AuthenticatorStateUpdateV1 was introduced by my team in #3173

@DaughterOfMars
Copy link
Contributor Author

Please revert the changes related to any version number removal.

ConsensusCommitPrologueV1 also exists on current upstream. AuthenticatorStateUpdateV1 was introduced by my team in #3173

Should I apply this to the external repo as well? It is removed upstream there.

@muXxer
Copy link
Contributor

muXxer commented Feb 5, 2025 •
edited
Loading

Should I apply this to the external repo as well? It is removed upstream there.

I think it would cleaner, yes.

@DaughterOfMars
Copy link
Contributor Author

Should I apply this to the external repo as well? It is removed upstream there.

I think it would cleaner, yes.

done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muXxer muXxer muXxer requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
dev-tools Issues related to the Developer Tools Team sc-platform Issues related to the Smart Contract Platform group.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaughterOfMars @muXxer @iota-ci