Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stronghold #2000

Closed
wants to merge 14 commits into from
Closed

Update stronghold #2000

wants to merge 14 commits into from

Conversation

Thoralf-M
Copy link
Member

Description of change

Update stronghold to v3

How the change has been tested

Running tests and the example

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@Thoralf-M Thoralf-M changed the title Firefly desktop2 Update stronghold Aug 1, 2023
Copy link

@semenov-vladyslav semenov-vladyslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

storage_password_to_encryption_key thing must definitely be fixed. There's no easy way to derive strong key from weak password and virtually no salt and iteration count.

src/account_manager.rs Show resolved Hide resolved
src/account_manager.rs Outdated Show resolved Hide resolved
src/account_manager.rs Outdated Show resolved Hide resolved
src/account_manager.rs Outdated Show resolved Hide resolved
src/actor/mod.rs Outdated Show resolved Hide resolved
src/stronghold/mod.rs Outdated Show resolved Hide resolved
src/stronghold/mod.rs Outdated Show resolved Hide resolved
src/stronghold/mod.rs Show resolved Hide resolved
@semenov-vladyslav
Copy link

semenov-vladyslav commented Aug 1, 2023

Regarding storage_password_to_encryption_key. As @Thoralf-M explained, the key derived with it is used to encrypt public data that doesn't need thorough protection (integrity guarantees provided by the inner DB would suffice). It would be good idea to get rid of this function and respective code in the future.

Copy link

@semenov-vladyslav semenov-vladyslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes required. Type of passwords should be unified.

src/stronghold/mod.rs Outdated Show resolved Hide resolved
src/stronghold/mod.rs Outdated Show resolved Hide resolved
src/stronghold/mod.rs Show resolved Hide resolved
@Thoralf-M Thoralf-M closed this Aug 2, 2023
@Thoralf-M Thoralf-M reopened this Aug 2, 2023
@Thoralf-M Thoralf-M closed this Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants