feat: Support downloading trace output, uploading to GCS #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for specifying the `--output` flag, which can either be: - stdout (the existing behavior) - A local path, resulting in the output being downloaded to a local location - A URI for a GCS path, to upload to google blob storage If the target is GCS, a corresponding application secret must be specified, indicating a kubernetes secret that contains a service account key with access to upload to GCS. In all cases, the output will be tee'd to stdout as well as any desired additional location. The primary author of the upload functionality was Zeeshan Qureshi, this commit is made on his behalf. Co-authored-by: Zeeshan Qureshi <[email protected]> Co-authored-by: Aaron Olson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for specifying the
--outputflag, which can either be:If the target is GCS, a corresponding application secret must be specified,
indicating a kubernetes secret that contains a service account key with
access to upload to GCS.
In all cases, the output will be tee'd to stdout as well as any desired
additional location.
The primary author of the upload functionality was Zeeshan Qureshi, this commit
is made on his behalf.
Co-authored-by: Zeeshan Qureshi [email protected]
Co-authored-by: Aaron Olson [email protected]