Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update build and release to produce arm64 #180

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

timfallmk
Copy link

@timfallmk timfallmk commented Dec 22, 2021

Adds new build parameters for the arm64 arch for macOS and linux. Windows may also be addable this way but is not done here.

Fixes #178

@timfallmk timfallmk marked this pull request as ready for review December 22, 2021 04:52
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Thanks for sending this patch! 💯

I reserve some time to try it out, tho

@timfallmk
Copy link
Author

@leodido Of course! I wasn't able to fully test it out in the existing build pipeline, just each piece manually.

@timfallmk
Copy link
Author

Just wanted to bump this for submission.

@Patrick0308
Copy link

Any progress on this pr

@timfallmk timfallmk changed the title Update build and release to produce arm64 build: Update build and release to produce arm64 Mar 18, 2022
Adds new build parameters for the arm64 arch for macOS and linux. Windows may also be addable this way but is not done here.
@timfallmk timfallmk force-pushed the apple-silicon-build branch from 241a048 to 30c51ce Compare March 18, 2022 19:58
@timfallmk timfallmk requested a review from leodido March 18, 2022 19:59
@fntlnz
Copy link
Member

fntlnz commented Apr 14, 2022

LGTM thanks @timfallmk

@fntlnz fntlnz merged commit 2ac216b into iovisor:master Apr 14, 2022
@timfallmk timfallmk deleted the apple-silicon-build branch April 14, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide builds for M series Apple Silicon Macs (darwin_arm64)
4 participants