refactor: only define usr-host volume if to be mounted by a container #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
changed the title
|
It makes sense @consideRatio this was a mistake in the first instance, thanks for fixing it! |
consideRatio
force-pushed
the
pr/only-def-usr-host-volume-when-needed
branch
from
1097bdd to
a660dfa
Compare
|
I rebased this PR on the current master branch. I think that should resolve the test failures previously observed where ubuntu-16.04 still was used. |
|
Thank you @consideRatio ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a
usr-hostVolume be conditionally added, side by side with the conditionally added VolumeMount entry referencing it.I think the current behavior of declaring a volume that isn't mounted will be fully functional, and this fix just makes it easier to understand the workload by not including an unused volume.