feat: migration from 14 to 15 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jorropo
reviewed
Aug 23, 2023
Co-authored-by: Jorropo <[email protected]>
lidel
force-pushed
the
14-to-15
branch
2 times, most recently
from
c083a7d
to
f025bd3
Compare
been a while, and it was pre go 1.20, skipping saves time and avoids potential issues when we build
lidel
reviewed
Aug 28, 2023
Comment on lines
+201
to
+203
| // Remove legacy Gateway.HTTPHeaders values that were hardcoded since years ago, but no longer necessary | ||
| // (but leave as-is if user made any changes) | ||
| // https://github.com/ipfs/kubo/issues/10005 |
There was a problem hiding this comment.
ℹ️ Added cleanup of Gateway.HTTPHeaders. It was a long time due.
Details and rationale in ipfs/kubo#10005
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first migration ❤️
Included migration tasks
/quic(draft 29) support kubo#9496