Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test implementations with reusable jsons #146

Merged
merged 6 commits into from
Aug 21, 2023

Conversation

@laurentsenta laurentsenta marked this pull request as draft August 21, 2023 08:34
@laurentsenta laurentsenta force-pushed the feat-reusable-jsons branch 3 times, most recently from 36ce1c9 to d157aed Compare August 21, 2023 08:43
@laurentsenta
Copy link
Contributor Author

@galargh
Copy link
Contributor

galargh commented Aug 21, 2023

explicit failure on misconfiguration: https://github.com/ipfs/gateway-conformance/actions/runs/5924017480/job/16060746449?pr=146#logs

I think we should catch it and report success if that's what we expect. Otherwise, it's quite confusing to contributors at this point (myself included) - #147.

laurentsenta added a commit to ipfs/boxo that referenced this pull request Aug 21, 2023
Upload the JSON logs as an artifact that the dashboard generation scripts can retrieve and process.

Support for ipfs/gateway-conformance#146
@laurentsenta
Copy link
Contributor Author

laurentsenta commented Aug 21, 2023

I think we should catch it and report success if that's what we expect. Otherwise, it's quite confusing to contributors at this point (myself included) - #147.

@galargh agreed, I think that one error is expected: the dahboard generation could not find the output.json and failed. It does not depend on the gateway test statuses, etc.

@laurentsenta laurentsenta merged commit 056725c into main Aug 21, 2023
15 of 19 checks passed
@laurentsenta laurentsenta deleted the feat-reusable-jsons branch August 21, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants