-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: test implementations with reusable jsons #146
Conversation
36ce1c9
to
d157aed
Compare
explicit failure on misconfiguration: https://github.com/ipfs/gateway-conformance/actions/runs/5924017480/job/16060746449?pr=146#logs |
I think we should catch it and report success if that's what we expect. Otherwise, it's quite confusing to contributors at this point (myself included) - #147. |
Upload the JSON logs as an artifact that the dashboard generation scripts can retrieve and process. Support for ipfs/gateway-conformance#146
@galargh agreed, I think that one error is expected: the dahboard generation could not find the output.json and failed. It does not depend on the gateway test statuses, etc. |
57853d2
to
2336e60
Compare
contributes to #123
depends on #145
example output: https://github.com/ipfs/gateway-conformance/actions/runs/5924237972/attempts/1#summary-16061404658
related: