Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cache-Control for generated UnixFS dir listings on /ipfs #219

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Conversation

lidel
Copy link
Member

@lidel lidel commented Jul 29, 2024

Applies #218 in a backward-compatible way, allowing us to ship as a patch release while we finalize the specs.

This allows us to ship this as backward-compatible fix
Copy link
Contributor

Results against Kubo latest:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
1309 0 0 0

Copy link
Contributor

Results against Kubo master:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
1309 0 0 0

@lidel
Copy link
Member Author

lidel commented Jul 29, 2024

Tested in ipfs/kubo#10464 and looked green there, we can ship this as v0.6.1 to unblock ipfs/boxo#639

@lidel lidel changed the title fix: Verify Cache-Control header for UnixFS directories fix: Cache-Control for generated UnixFS dir listings on /ipfs Jul 29, 2024
Copy link
Contributor

v0.6.1

Changed

  • Support meaningful Cache-Control on generated UnixFS directory listing responses on /ipfs namespace

@lidel lidel merged commit f1d01d3 into main Jul 29, 2024
10 of 12 checks passed
@lidel lidel deleted the pr-218 branch July 29, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants