Add: StatusMatch function for elegantly handingling Status Checks #220
Conversation
| re := regexp.MustCompile(`^(\d+)(x+)$`) | ||
| matches := re.FindStringSubmatch(pattern) | ||
| if len(matches) != 3 { | ||
| panic("invalid status pattern") |
There was a problem hiding this comment.
I am not a gopher here. Will this be an error when building or when the test runs?
If the former, a panic is appropriate. If the latter, we should not panic.
Either way, can we be more explicit with the error message to indicate the action to be taken? For example: "The StatusMatch pattern must be a string representing a three-digit status code. Either 5xx, 50x, 502, etc."
| // Compute the lower bound | ||
| from, err := strconv.Atoi(leadingDigits + strings.Repeat("0", numXs)) | ||
| if err != nil { | ||
| panic(fmt.Sprintf("invalid status pattern: %v", err)) |
There was a problem hiding this comment.
ditto on panic and more explicit error message.
| // Compute the upper bound | ||
| to, err := strconv.Atoi(leadingDigits + strings.Repeat("9", numXs)) | ||
| if err != nil { | ||
| panic(fmt.Sprintf("invalid status pattern: %v", err)) |
There was a problem hiding this comment.
ditto on panic and more explicit error message.
| @@ -162,6 +165,34 @@ func (e ExpectBuilder) Status(statusCode int) ExpectBuilder { | |||
| return e | |||
| } | |||
|
|
|||
| func (e ExpectBuilder) StatusMatch(pattern string) ExpectBuilder { | |||
There was a problem hiding this comment.
nit: Maybe we should go with Status since it's BDD style testing expectation language. "expect status X" instead of "expect StatusMatch X"
| e.StatusCodeTo_ = to | ||
| return e | ||
| } | ||
|
|
||
| func (e ExpectBuilder) StatusBetween(from, to int) ExpectBuilder { |
There was a problem hiding this comment.
Are we using this function elsewhere? @lidel Are there any cases where we would want to do 501-503 or other?
There was a problem hiding this comment.
I don't think so, in practice we care about specific code(s), or 4XX or 5XX.
This PR adds a function
StatusMatchto handle status checks for ranges of HTTP status codes.Aims to resolve the issue #164