Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: order of releases in changelog #492

Merged
merged 4 commits into from
Apr 15, 2024
Merged

chore: order of releases in changelog #492

merged 4 commits into from
Apr 15, 2024

Conversation

2color
Copy link
Member

@2color 2color commented Apr 9, 2024

chore: order of releases in changelog #492

@2color 2color requested a review from a team as a code owner April 9, 2024 13:58
@SgtPooki
Copy link
Member

SgtPooki commented Apr 9, 2024

these are autogenerated. I wonder if something is misconfigured in semantic-release or there's a bug?

@achingbrain
Copy link
Member

We've been through a couple of different release tools which format things differently, and code has been moved around without trimming the release logs, it's a bit of a mess.

Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably try to re-generate the changelog completely using semantic-release.

packages/helia/CHANGELOG.md Outdated Show resolved Hide resolved
@achingbrain
Copy link
Member

Notably I think some of the @helia/xxx code has been through at least semantic-release, semantic-release-monorepo, @anolilab/multi-semantic-release and now finally release-please 😅 .

@SgtPooki
Copy link
Member

SgtPooki commented Apr 9, 2024

@achingbrain if we remove the changelogs in #483 can we get release-please to regenerate the full changelog?

@achingbrain
Copy link
Member

I don't know tbh, but my guess would be no. I think it only considers changes since the last release tag, otherwise we'd see CI releases failing all over the place due to GitHub applying rate limiting (this happens when you stuff up the release-please config, for example).

@2color 2color requested a review from SgtPooki April 12, 2024 10:26
@achingbrain
Copy link
Member

Ok, I've updated the formatting of all changelogs to be consistent with the latest release tool.

I've also re-tagged all the old releases from the @helia/foo-vNNN format to foo-vNNN and removed the old tags so everything's consistent.

Please delete your local tags in any cloned copy of helia you have and fetch the updated list (this will prevent you re-creating the old tag formats if you accidentally run git push --tags, for example):

$ git tag -l | xargs git tag -d
$ git fetch

Hopefully going forwards everything autogenerated will be done just so.

@achingbrain achingbrain merged commit 9c8a2c0 into main Apr 15, 2024
18 checks passed
@achingbrain achingbrain deleted the changelog-order branch April 15, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants