fix: align implicit default ttl with specs #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowering TTL to 5m due to ipfs/specs#492 lifetime is validity of signature, and that should be fine up to 48h, to match DHT expiration window
lidel
force-pushed
the
fix-ipns-defaults
branch
from
6c36281 to
693e3b1
Compare
2color
approved these changes
Feb 27, 2025
achingbrain
changed the title
achingbrain
reviewed
Feb 27, 2025
| @@ -327,7 +327,7 @@ export interface PublishOptions extends AbortOptions, ProgressOptions<PublishPro | |||
| v1Compatible?: boolean | |||
|
|
|||
| /** | |||
| * The TTL of the record in ms (default: 1 hour) | |||
| * The TTL of the record in ms (default: 5 minutes) | |||
There was a problem hiding this comment.
Maybe I'm missing something but the suggested default is one hour?
There was a problem hiding this comment.
Aha! Like it says in the issue description..
achingbrain
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
chore(ipns): align implicit default ttl with specs
Description
Notes & open questions
Change checklist