Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kubo 0.34 + electron 35 #2936

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -230,9 +230,6 @@ jobs:
max_attempts: 2
# GH token for attaching atrifacts to release draft on tag build
github_token: ${{ secrets.github_token }}
# Windows signing
windows_certs: ${{ secrets.windows_certs }}
windows_certs_password: ${{ secrets.windows_certs_password }}
# Apple signing
mac_certs: ${{ secrets.mac_certs }}
mac_certs_password: ${{ secrets.mac_certs_password }}
Expand All @@ -244,6 +241,10 @@ jobs:
# Apple notarization
APPLEID: ${{ secrets.apple_id }}
APPLEIDPASS: ${{ secrets.apple_id_pass }}
# Windows Azure Trusted Signing
AZURE_TENANT_ID: ${{secrets.AZURE_TENANT_ID}}
AZURE_CLIENT_ID: ${{secrets.AZURE_CLIENT_ID}}
AZURE_CLIENT_SECRET: ${{secrets.AZURE_CLIENT_SECRET}}

- name: Show dist/
run: du -sh dist/ && ls -l dist/
Expand Down
14 changes: 14 additions & 0 deletions electron-builder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,28 @@ dmg:
type: link
path: /Applications

win:
target:
- nsis
# TODO - portable
azureSignOptions:
publisherName: 'IPFS Project'
endpoint: 'https://eus.codesigning.azure.net'
certificateProfileName: 'ipfs-desktop'
codeSigningAccountName: 'pl-code-signing'

nsis:
artifactName: ${name}-setup-${version}-${os}-${arch}.${ext}
include: assets/build/nsis.nsh
oneClick: false
warningsAsErrors: false
perMachine: false
allowElevation: true
allowToChangeInstallationDirectory: true

portable:
artifactName: ${name}-portable-${version}-${os}-${arch}.${ext}

linux:
artifactName: ${name}-${version}-${os}-${arch}.${ext}
executableName: ipfs-desktop
Expand Down
Loading