Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: probe for local gateway and add to config #403

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Oct 24, 2024

Title

feat: probe for local gateway and add to config

Description

Replaces #303
Fixes #288
Fixes #299

Notes & open questions

Not tested. Only created because merge conflicts on #303 and git saying no related history

This has been tested, and the local gateway check is working properly. I am thinking that we need to add a UI toggle to disable adding it, but we might need to refactor the local-storage inputs and lift up the accessing of those inputs.. or handle the adding of the localStorage gateway when we save

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@SgtPooki SgtPooki requested review from 2color and removed request for 2color October 29, 2024 15:34
@SgtPooki SgtPooki marked this pull request as draft October 29, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ux: detect local trustless gw and default to it ux: add configuration toggle for delegated routing
1 participant