-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow loading config page from subdomain after sw registration #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 8, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Mar 8, 2024
Base automatically changed from
fix/refactor-for-cache-patch
to
refactor-for-cache
March 8, 2024 19:07
6 tasks
We can create an easy reset for users by adding a #ipfs-sw-reset pathname flag that triggers the following code:
It would be good to make sure this is in-place before changing the sw name. |
2color
reviewed
Mar 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
feat: pass through helia service worker assets & config page requests
Description
This fix allows you to reload the redirectPage (config in iframe) on any service worker registered in a subdomain by simply appending
#/ipfs-sw-config
to the URL.It also passes through requests of the service worker source javascript to the server, which it didn't previously do.
NOTE: subdomains don't automatically refresh the service worker.. so we need some clever logic for checking for service worker assets, and then redirecting to /#/ipfs-sw-config again. We can handle this later? I will call this out in #31
Notes & open questions
/config /#/ipfs-sw-config 302
from the _redirects file now?This is built on top of #95 which is built on top of #89
Demo
2024-03-07.at.21.17.26.-.Orange.Unicorn.mp4
Change checklist