Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS Principles #390

Merged
merged 9 commits into from
Mar 31, 2023
Merged

IPFS Principles #390

merged 9 commits into from
Mar 31, 2023

Conversation

darobin
Copy link
Contributor

@darobin darobin commented Mar 28, 2023

This is the PR for the IPFS Principles draft we have been working on. I'm keeping it as a draft pending further feedback and also because it needs the site to land before it can land.

I hesitated but I didn't file an IPIP with this on the grounds that it doesn't add or modify any implementation. That being said these considerations are potentially load-bearing and this document might end up being referred to a fair bit, so I'm happy to add an IPIP if others prefer it that way!

@darobin darobin changed the base branch from main to try-ipseity March 28, 2023 16:06
src/architecture/index.html Outdated Show resolved Hide resolved
src/architecture/index.html Outdated Show resolved Hide resolved
src/architecture/principles.md Show resolved Hide resolved
src/architecture/principles.md Outdated Show resolved Hide resolved
src/architecture/principles.md Outdated Show resolved Hide resolved
src/architecture/principles.md Show resolved Hide resolved
src/architecture/principles.md Outdated Show resolved Hide resolved
src/architecture/principles.md Show resolved Hide resolved
src/architecture/principles.md Outdated Show resolved Hide resolved
src/architecture/principles.md Show resolved Hide resolved
@darobin darobin marked this pull request as ready for review March 29, 2023 19:06
Base automatically changed from try-ipseity to main March 29, 2023 19:44
Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the preview: https://bafybeigii6yqtyon4ourvh3gyeverx52jnn4ltsbwiulgdzulzbwn7xspu.on.fleek.co/architecture/principles/

Great work @darobin!

I assume we'll discuss more at 2023-03-30 implementer's sync, but I also don't see a lot of harm merging this soon and improving with followups.

src/architecture/principles.md Outdated Show resolved Hide resolved
@aschmahmann
Copy link
Contributor

Left a small correction, but looks pretty good 😄. Thanks @darobin and everyone who helped make this happen 🙏.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent gift to the IPFS community, thank you @darobin ❤️

src/architecture/principles.md Show resolved Hide resolved
src/architecture/principles.md Show resolved Hide resolved
src/architecture/principles.md Show resolved Hide resolved
src/architecture/principles.md Show resolved Hide resolved
@lidel lidel requested a review from autonome March 31, 2023 17:20
@lidel lidel merged commit 48da7a6 into main Mar 31, 2023
@lidel lidel deleted the ipfs-principles branch March 31, 2023 18:51
Copy link

@autonome autonome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

(x1000)

Copy link

@autonome autonome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this will close it out.

no. apparently you can't close a review on an already merged pr.

my review will live forever unresolved, like a obelisk to the living document it was in service of.

@BigLep BigLep linked an issue Apr 6, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Define the loose/minimal IPFS definition
5 participants