Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add notification, remove statusicon and soundsystem #415

Merged
merged 17 commits into from
Apr 3, 2021

Conversation

lidaobing
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 3, 2021

Codecov Report

Merging #415 (00dd1e4) into master (b284957) will decrease coverage by 0.20%.
The diff coverage is 31.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
- Coverage   42.87%   42.67%   -0.21%     
==========================================
  Files          70       72       +2     
  Lines        8032     7735     -297     
==========================================
- Hits         3444     3301     -143     
+ Misses       4588     4434     -154     
Impacted Files Coverage Δ
src/api/iptux-core/Models.h 100.00% <ø> (ø)
src/api/iptux-core/ProgramData.h 75.00% <ø> (ø)
src/iptux/Application.h 100.00% <ø> (ø)
src/iptux/DataSettings.cpp 50.60% <ø> (-3.20%) ⬇️
src/iptux/DataSettings.h 0.00% <ø> (ø)
src/iptux/GioNotificationService.cpp 0.00% <0.00%> (ø)
src/iptux/MainWindow.cpp 25.47% <ø> (+0.08%) ⬆️
src/iptux/TerminalNotifierNotificationService.cpp 0.00% <0.00%> (ø)
src/iptux/TerminalNotifierNotificationService.h 0.00% <0.00%> (ø)
src/iptux/UiProgramData.cpp 83.67% <ø> (+3.28%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b284957...00dd1e4. Read the comment docs.

@lidaobing lidaobing changed the title Lidaobing/issue364 add notification, remove statusicon and soundsystem Apr 3, 2021
@lidaobing lidaobing merged commit edde2ce into master Apr 3, 2021
@lidaobing lidaobing linked an issue Apr 3, 2021 that may be closed by this pull request
@lidaobing lidaobing deleted the lidaobing/issue364 branch April 8, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove statusicon, replace with g_application_send_notification
1 participant