Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Portuguese channels #15708

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add Portuguese channels #15708

wants to merge 11 commits into from

Conversation

thomraider12
Copy link

added:

  • StarChannel.pt
  • StarLife.pt
  • StarComedy.pt
  • StarMovies.pt

changed logo of:

  • VPlusTVI.pt

@thomraider12
Add Portuguese channels
d3307e8 
added:
- StarChannel.pt
- StarLife.pt
- StarComedy.pt
- StarMovies.pt

changed logo of:
- VPlusTVI.pt
@thomraider12 thomraider12 mentioned this pull request Feb 2, 2025
Draft
@Alstruit
Copy link
Contributor

Alstruit commented Feb 2, 2025

https://github.com/iptv-org/database/blob/master/CONTRIBUTING.md

@Alstruit Alstruit closed this Feb 2, 2025
@thomraider12
Copy link
Author

https://github.com/iptv-org/database/blob/master/CONTRIBUTING.md

That's what I did. No clue why you closed it.

@PopeyeTheSai10r
Copy link
Contributor

PopeyeTheSai10r commented Feb 7, 2025 •
edited
Loading

Hey @thomraider12, Which ever code editor you used to made the changes saved the file incorrectly. It saved it as if everything was changed.

https://github.com/iptv-org/database/pull/15708/files

39,195 additions, 39,190 deletions not shown because the diff is too large. Please use a local Git client to view these changes.

You will either need to use a different editor or try submitting the changes via issues.

@thomraider12
Copy link
Author

Ok, thanks.

@BellezaEmporium
Copy link
Contributor

Reopening on my behalf, found the issue.

@BellezaEmporium
Copy link
Contributor

Now we're seeing something.

@BellezaEmporium
Copy link
Contributor

Here's why your PR isn't passing the tests :

27657 "StarComedy.pt" must be derived from the channel name "STAR Comedy" and the country code "PT"
27660 "StarCrime.pt" must be derived from the channel name "STAR Crime" and the country code "PT"
27688 "StarLife.pt" must be derived from the channel name "STAR Life" and the country code "PT"

^ For these specific errors, the bot asks you to be coherent with your naming choices. If you name a channel STAR Comedy, then the ID should be STARComedy.pt.

27660 "StarCrime.pt" has an invalid categories "crime"

^ For this error, we will ask you to check the categories we accept at https://github.com/iptv-org/database/blob/master/data/categories.csv, and choose the closest category (or categories) corresponding to your channel.

27657 StarComedy.pt: "logo" has an invalid file extension ".svg"
27660 StarCrime.pt: "logo" has an invalid file extension ".svg"
27702 STARMovies.pt: "logo" has an invalid file extension ".svg"

^ For these errors, we will ask you to use .png, or .jpg images. The bot and programs using the database do not understand the .svg format yet, so please refrain from using them. Please use the .jpg, .jpeg. or .png format for the logos.

@thomraider12
Copy link
Author

Here's why your PR isn't passing the tests :

27657 "StarComedy.pt" must be derived from the channel name "STAR Comedy" and the country code "PT" 27660 "StarCrime.pt" must be derived from the channel name "STAR Crime" and the country code "PT" 27688 "StarLife.pt" must be derived from the channel name "STAR Life" and the country code "PT"

^ For these specific errors, the bot asks you to be coherent with your naming choices. If you name a channel STAR Comedy, then the ID should be STARComedy.pt.

27660 "StarCrime.pt" has an invalid categories "crime"

^ For this error, we will ask you to check the categories we accept at https://github.com/iptv-org/database/blob/master/data/categories.csv, and choose the closest category (or categories) corresponding to your channel.

27657 StarComedy.pt: "logo" has an invalid file extension ".svg" 27660 StarCrime.pt: "logo" has an invalid file extension ".svg" 27702 STARMovies.pt: "logo" has an invalid file extension ".svg"

^ For these errors, we will ask you to use .png, or .jpg images. The bot and programs using the database do not understand the .svg format yet, so please refrain from using them. Please use the .jpg, .jpeg. or .png format for the logos.

I will try to fix that tomorrow. My PC broke down and when it gets fixed I'll do it. Thanks man.

@BellezaEmporium BellezaEmporium marked this pull request as draft February 14, 2025 23:43
@thomraider12
Copy link
Author

What about now? I think I solved all those problems.

@thomraider12 thomraider12 marked this pull request as ready for review February 16, 2025 14:07
@BellezaEmporium
Copy link
Contributor

BellezaEmporium commented Feb 17, 2025 •
edited
Loading

31083 "TVIFiccao.pt" must be derived from the channel name "TVI Ficção" and the country code "PT"
31083 TVIFiccao.pt: "name" with value "TVI Ficção" fails to match the required pattern: /^[a-z0-9-!:&.+'/»#%°$@?|¡–\s_—]+$/i

Main rule for the channel name is to write the channel name without any accents, and then "romanize the name" as an alternative name, to make sure all browsers and players can read the channel name properly.

@thomraider12
Copy link
Author

31083 "TVIFiccao.pt" must be derived from the channel name "TVI Ficção" and the country code "PT" 31083 TVIFiccao.pt: "name" with value "TVI Ficção" fails to match the required pattern: /^[a-z0-9-!:&.+'/»#%°$@?|¡–\s_—]+$/i

Main rule for the channel name is to write the channel name without any accents, and then "romanize the name" as an alternative name, to make sure all browsers and players can read the channel name properly.

Oh, thanks.

Alstruit
Alstruit requested changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@Alstruit Alstruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See requested changes.

data/channels.csv
@@ -27695,6 +27699,7 @@ StarMaaMoviesHD.in,Star Maa Movies HD,,Disney Star,Disney India,IN,,Hyderabad,c/
StarMaaMusic.in,Star Maa Music,Maa Music,Disney Star,Disney India,IN,,Hyderabad,c/IN,tel,music,FALSE,2008-01-01,,,https://www.hotstar.com/in/channels/star-maa,https://i.imgur.com/vxP9L8p.png
StarMax.pk,Star Max,,,,PK,,,c/PK,eng,,FALSE,,,,,https://i.imgur.com/patxMdp.png
StarMovies.in,Star Movies,,Disney Star,Disney India,IN,,Mumbai,c/IN,eng;hin;tam,movies,FALSE,1991-04-01,,,http://www.starmovies.in/,https://upload.wikimedia.org/wikipedia/commons/thumb/5/54/STAR_Movies_logo.svg/512px-STAR_Movies_logo.svg.png
StarMovies.pt,Star Movies,,The Walt Disney Company Portugal,The Walt Disney Company Iberia S.L.,PT,,Lisboa,c/PT,por,movies,FALSE,2024-02-07,,,https://www.startv.pt/programacao/starmovie,https://upload.wikimedia.org/wikipedia/commons/thumb/0/08/Star_Movies_2023.svg/1920px-Star_Movies_2023.svg.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image must be under 512px.

data/channels.csv
@@ -27682,6 +27685,7 @@ StarKids.tz,Star Kids,,,,TZ,,,c/TZ,swa,kids,FALSE,,,,,https://i.imgur.com/OlsUSI
StarLife.bg,Star Life,Fox Life,,The Walt Disney Company Bulgaria EOOD,BG,,Sofia,c/BG,bul,series,FALSE,,,,https://www.starchannel-bg.com/,https://i.imgur.com/1CEnGOa.png
StarLife.br,Star Life,Star Life Brasil,,,BR,,,c/BR,por,,FALSE,,,,https://www.star-brasil.com/,https://upload.wikimedia.org/wikipedia/commons/thumb/f/f9/Star_Life_2021.svg/512px-Star_Life_2021.svg.png
StarLife.mx,Star Life,,,,MX,,,c/MX,spa,,FALSE,,,,https://www.star-latam.com/,https://upload.wikimedia.org/wikipedia/commons/thumb/f/f9/Star_Life_2021.svg/512px-Star_Life_2021.svg.png
StarLife.pt,Star Life,,The Walt Disney Company Portugal,The Walt Disney Company Iberia S.L.,PT,,Lisboa,c/PT,por,lifestyle,FALSE,,,,https://www.startv.pt/programacao/starlife,https://upload.wikimedia.org/wikipedia/commons/thumb/f/f9/Star_Life_2021.svg/800px-Star_Life_2021.svg.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image must be under 512px.

data/channels.csv
StarComedy.us,Star Comedy,,,,US,,,c/US,eng,comedy,FALSE,,,,,https://i.imgur.com/B5mfsxU.png
StarCrime.bg,Star Crime,Fox Crime,,The Walt Disney Company Bulgaria EOOD,BG,,Sofia,c/BG,bul,series,FALSE,,,,https://www.starchannel-bg.com/,https://i.imgur.com/BOSxgfl.png
StarCrime.pt,Star Crime,,The Walt Disney Company Portugal,The Walt Disney Company Iberia S.L.,PT,,Lisboa,c/PT,por,lifestyle,FALSE,,,,https://www.startv.pt/programacao/starcrime,https://upload.wikimedia.org/wikipedia/commons/thumb/4/40/Star_Crime_2023.svg/1920px-Star_Crime_2023.svg.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image must be under 512px.

data/channels.csv
@@ -27653,8 +27654,10 @@ StarCinema.ru,Star Cinema,,,,RU,,,c/RU,rus,movies,FALSE,2018-08-06,,,http://star
StarCinema.ua,Star Cinema,,,,UA,,,c/UA,ukr,movies,FALSE,2016-02-01,,,http://starcinema.starmediatv.ru/,https://i.imgur.com/5sis895.png
StarCinema.us,Star Cinema,,,,US,,,c/US,eng,movies,FALSE,,,,,https://i.imgur.com/ObViBTR.png
StarClassics.us,Star Classics,,,,US,,,c/US,eng,classic,FALSE,,,,,https://i.imgur.com/cv2XIQQ.png
StarComedy.pt,Star Comedy,,The Walt Disney Company Portugal,The Walt Disney Company Iberia S.L.,PT,,Lisboa,c/PT,por,comedy,FALSE,2024-02-07,,,https://www.startv.pt/programacao/starcomedy,https://upload.wikimedia.org/wikipedia/commons/thumb/5/5a/Star_Comedy_2024.svg/1200px-Star_Comedy_2024.svg.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image must be under 512px.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alstruit Alstruit Alstruit requested changes

@BellezaEmporium BellezaEmporium BellezaEmporium approved these changes

@Dum4G Dum4G Awaiting requested review from Dum4G

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomraider12 @Alstruit @PopeyeTheSai10r @BellezaEmporium