Fix according to comments

iree-org · Feb 4, 2025 · 11c4ae0 · 11c4ae0
1 parent 70862e7
commit 11c4ae0
Showing 1 changed file with 12 additions and 10 deletions.
diff --git a/compiler/src/iree/compiler/Codegen/Common/PolynomialApproximationPass.cpp b/compiler/src/iree/compiler/Codegen/Common/PolynomialApproximationPass.cpp
@@ -35,6 +35,17 @@ class PolynomialApproximationPass final
   void runOnOperation() override {
 
     using PatternFunction = llvm::function_ref<void(RewritePatternSet &)>;
+
+    auto populateErfPattern = [&](RewritePatternSet &patterns) {
+      if (clNativeMathPrecision) {
+        patterns.add<math::ErfPolynomialApproximation>(&getContext());
+      } else {
+        populateExpandExp2FPattern(patterns);
+        populateMathPolynomialApproximationPatterns(patterns);
+        populateExpandRoundEvenPattern(patterns);
+      }
+    };
+
     // Order matters here.
     llvm::SmallVector<std::pair<StringRef, PatternFunction>> patternMap = {
         {"tan", populateExpandTanPattern},
@@ -45,16 +56,7 @@ class PolynomialApproximationPass final
         {"atanh", populateExpandAtanhPattern},
         {"powf", populateExpandPowFPattern},
         {"fpowi", populateExpandFPowIPattern},
-        {"erf",
-         [&](RewritePatternSet &patterns) {
-           if (clNativeMathPrecision) {
-             patterns.add<math::ErfPolynomialApproximation>(&getContext());
-           } else {
-             populateExpandExp2FPattern(patterns);
-             populateMathPolynomialApproximationPatterns(patterns);
-             populateExpandRoundEvenPattern(patterns);
-           }
-         }},
+        {"erf", populateErfPattern},
     };
 
     RewritePatternSet mathPatterns(&getContext());