Revert LLVM changes from #19007 #19153
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See iree-org#19135 for a discussion. Signed-off-by: Andrzej Warzynski <[email protected]>
banach-space
force-pushed
the
andrzej/revert_112907
branch
from
fe26d41
to
76b99f7
Compare
|
Looks like the commit isn't reachable. |
Groverkss
approved these changes
Nov 14, 2024
|
LGTM, Just want to give @MaheshRavishankar a signal too. I don't think there should be any patches / patterns that depend on this patch, because it just eliminates a corner case in a lowering pattern. So it should be okay to keep the revert for a week or so. |
|
I am discussing the underlying issue here: It's a bit nuanced and needs a bit of thinking.
This is high priority for me and ~1 week should be sufficient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #19135 for a discussion.
Signed-off-by: Andrzej Warzynski [email protected]