Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit scheduling jobs to iree-org #19224

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Limit scheduling jobs to iree-org #19224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fc5dc5b
Limit scheduling candidate releases to iree-org
marbre Nov 20, 2024
e8f1970
Run samples on schedule only in iree-org
marbre Nov 20, 2024
f23fb5f
Run on `pull_request` and `workflow_dispatch`
marbre Dec 11, 2024
1bd1cb8
Only run Arm64 workflow in iree-org
marbre Dec 11, 2024
51c65ef
Only run Windows workflow in iree-org
marbre Dec 11, 2024
f9ae84d
Remove setup job
marbre Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci_linux_arm64_clang.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ concurrency:

jobs:
linux_arm64_clang:
if: ${{ github.repository_owner == 'iree-org' }}
# See https://gitlab.arm.com/tooling/gha-runner-docs
runs-on: ah-ubuntu_22_04-c7g_4x-50
container:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/ci_linux_x64_clang_debug.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ jobs:
# This may run out of memory / disk space on standard GitHub-hosted runners,
# so run on self-hosted CPU build runners instead.
linux_x64_clang_debug:
runs-on: azure-linux-scale
if: ${{ github.repository_owner == 'iree-org' || github.event_name != 'schedule' }}
runs-on: ${{ github.repository_owner == 'iree-org' && 'azure-linux-scale' || 'ubuntu-24.04' }}
container: ghcr.io/iree-org/cpubuilder_ubuntu_jammy@sha256:78a558b999b230f7e1da376639e14b44f095f30f1777d6a272ba48c0bbdd4ccb
defaults:
run:
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/ci_linux_x64_clang_tsan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,9 @@ concurrency:
cancel-in-progress: true

jobs:
setup:
uses: ./.github/workflows/setup.yml

linux_x64_clang_tsan:
needs: setup
runs-on: azure-linux-scale
if: ${{ github.repository_owner == 'iree-org' || github.event_name != 'schedule' }}
runs-on: ${{ github.repository_owner == 'iree-org' && 'azure-linux-scale' || 'ubuntu-24.04' }}
container:
image: ghcr.io/iree-org/cpubuilder_ubuntu_jammy@sha256:78a558b999b230f7e1da376639e14b44f095f30f1777d6a272ba48c0bbdd4ccb
# TSan in particular needs some settings that this option includes:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci_windows_x64_msvc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ concurrency:

jobs:
windows_x64_msvc:
if: ${{ github.repository_owner == 'iree-org' || github.event_name != 'schedule' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we could ideally also select the runs-on based on the repository[_owner], if this comment were addressed: #18967 (comment)

Ideally we could make this workflow more agnostic to the specific runner, so it can run in forks. One code pattern for that is https://github.com/openxla/stablehlo/blob/b1c1115f070493845ad92bd4a4461f77a2aa628d/.github/workflows/buildAndTestBazel.yml#L39

    runs-on: ${{ github.repository == 'openxla/stablehlo' && 'ubuntu-22.04-64core' ||  'ubuntu-22.04'  }}

Something to aim for later. All the build directory setup that is specific to these Azure runners will make that difficult and will limit workflow debugging to only developers with write access to this project.

A middle ground is possible where the runs-on field has a branch and the Create build dir step only runs if ${{ github.repository == or if ${{ runs-on == arc-runner-set.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in particular the Windows build wont run on a GH-hosted runner (due to all the sccache and Azure stuff).

runs-on: azure-windows-scale
env:
BASE_BUILD_DIR_POWERSHELL: C:\mnt\azure\b
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/samples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ concurrency:

jobs:
colab:
if: ${{ github.repository_owner == 'iree-org' || github.event_name != 'schedule' }}
runs-on: ubuntu-24.04
steps:
- name: "Checking out repository"
Expand All @@ -40,6 +41,7 @@ jobs:
run: ./samples/colab/test_notebooks.py

samples:
if: ${{ github.repository_owner == 'iree-org' || github.event_name != 'schedule' }}
runs-on: ubuntu-24.04
env:
CC: clang
Expand All @@ -59,6 +61,7 @@ jobs:
run: ./build_tools/testing/test_samples.sh

web:
if: ${{ github.repository_owner == 'iree-org' || github.event_name != 'schedule' }}
runs-on: ubuntu-24.04
env:
VENV_DIR: ${{ github.workspace }}/.venv
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/schedule_candidate_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ on:

jobs:
tag_release:
if: ${{ github.repository_owner == 'iree-org' || github.event_name != 'schedule' }}
name: "Tag candidate release"
runs-on: ubuntu-24.04
steps:
Expand Down
Loading