[Codegen] Sprinkle in PropagateDispatchSizeBounds passes #19677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzysz00
requested review from
antiagainst,
MaheshRavishankar,
kuhar,
qedawkins,
Groverkss,
hanhanW,
pashu123 and
benvanik
as code owners
Add a model of ValueBoundsOpInterface (the one used for reasoning about affine maps and loops) to the HAL ID ops and util.assume.int to improve both loop invariant code motion and, in the future, single-iteration loop removal.
krzysz00
force-pushed
the
users/krzysz00/value-bound-hal-ops
branch
from
6cdfa93 to
6c59ac1
Compare
Since the various tiling and distribution don't know how to set the upper bounds on workitem or workgroup IDs - even if that information is known from context, we use the PropagateDispatchSizeBounds pass to add that information before passes that use it. The mani passes that use this information are those that use the ValueBoundsOpInterface - that is, loop invariant code motion, some vectorization code, and, in an upcoming commit, RemoveSingleIterationLoop. These calls can be removed in the future, but they'll do for now.
krzysz00
force-pushed
the
users/krzysz00/propagate-dispatch-sizes-everywhere
branch
from
3c1b7ec to
6d06506
Compare
krzysz00
deleted the
users/krzysz00/propagate-dispatch-sizes-everywhere
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the various tiling and distribution don't know how to set the upper bounds on workitem or workgroup IDs - even if that information is known from context, we use the PropagateDispatchSizeBounds pass to add that information before passes that use it.
The mani passes that use this information are those that use the ValueBoundsOpInterface - that is, loop invariant code motion, some vectorization code, and, in an upcoming commit,
RemoveSingleIterationLoop.
These calls can be removed in the future, but they'll do for now.