[Codegen] Use linearize_index op when swapping slice and expand #19730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max191
requested review from
MaheshRavishankar,
qedawkins,
kuhar,
Groverkss,
antiagainst and
hanhanW
as code owners
|
Based on #19729 Edit: rebased now |
krzysz00
reviewed
Jan 17, 2025
hanhanW
reviewed
Jan 20, 2025
Max191
force-pushed
the
swap-expand-extract-use-linearize-op
branch
from
074598c to
27ad63d
Compare
Max191
force-pushed
the
swap-expand-extract-use-linearize-op
branch
from
57204f5 to
0986ee7
Compare
Signed-off-by: Max Dawkins <[email protected]>
Signed-off-by: Max Dawkins <[email protected]>
Signed-off-by: Max Dawkins <[email protected]>
Max191
force-pushed
the
swap-expand-extract-use-linearize-op
branch
from
0986ee7 to
a5eacb0
Compare
qedawkins
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the affine.apply used for index computation in
SwapExpandShapeWithSlicePatternwith anaffine.linearize_indexop. This is a more canonical form, and will make CSE easier with index computation generated by other similar patterns.