Fix or work around gcc-14 warnings/errors.

[ScottTodd]

Fixing or working around a few "warnings as errors" on gcc-14 (released May 2024). These are also causing the aarch64 nightly distribution builds to fail. Note that we also have some new warnings as errors coming in clang-20 (not yet released): https://clang.llvm.org/docs/ReleaseNotes.html#improvements-to-clang-s-diagnostics.

dangling-reference

Not sure how we want to handle these. We have a bunch of code in IREE and torch-mlir that uses temporaries in loop headers, which this warning does not like. For now just disabling the warning.

/iree/compiler/src/iree/compiler/API/Internal/Diagnostics.cpp: In function 'std::optional<mlir::CallSiteLoc> mlir::iree_compiler::embed::{anonymous}::getCallSiteLoc(mlir::Location)':
/iree/compiler/src/iree/compiler/API/Internal/Diagnostics.cpp:30:57: error: possibly dangling reference to a temporary [-Werror=dangling-reference]
   30 |     for (auto subLoc : cast<FusedLoc>(loc).getLocations()) {
      |                                                         ^
/iree/compiler/src/iree/compiler/API/Internal/Diagnostics.cpp:30:56: note: the temporary was destroyed at the end of the full expression 'llvm::cast<mlir::FusedLoc, mlir::Location>(loc).mlir::FusedLoc::getLocations()'
   30 |     for (auto subLoc : cast<FusedLoc>(loc).getLocations()) {
      |                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~

template-id-cdtor

These looked legit and were easy enough to fix.

/iree/compiler/src/iree/compiler/Dialect/LinalgExt/Transforms/ConvertConv2DToWinograd.cpp:159:33: error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]
  159 |   ConvertConvToWinograd<ConvOp>(MLIRContext *context, bool replaceAllConvs,
      |                                 ^~~~~~~~~~~
/iree/compiler/src/iree/compiler/Dialect/LinalgExt/Transforms/ConvertConv2DToWinograd.cpp:159:33: note: remove the '< >'

[kuhar]

Annoying? ✅

[ScottTodd]

cc1plus: error: unrecognized command line option '-Wno-dangling-reference' [-Werror]

argh, older versions of gcc don't recognize this option
https://github.com/iree-org/iree/actions/runs/12905050255/job/35983453401#step:4:6256

will try to fix-forward with something like GCC_GTE_XYZ

iree/build_tools/cmake/iree_macros.cmake

Line 393 in a430695

"ALL;CLANG;CLANG_GTE_10;CLANG_GTE_12;CLANG_CL;MSVC;GCC;CLANG_OR_GCC;MSVC_OR_CLANG_CL"