[DispatchCreation] Changes to dispatch region in preparation for horizontal fusion changes. #19876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
MaheshRavishankar
force-pushed
the
noconcat_horizontal_fusion_dispatch_region
branch
2 times, most recently
from
b2edb4d to
48e3cf5
Compare
IanWood1
reviewed
Feb 4, 2025
compiler/src/iree/compiler/DispatchCreation/FormDispatchRegions.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/DispatchCreation/FormDispatchRegions.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/DispatchCreation/FormDispatchRegions.cpp
Outdated
Show resolved
Hide resolved
MaheshRavishankar
force-pushed
the
noconcat_horizontal_fusion_dispatch_region
branch
from
48e3cf5 to
3b1709f
Compare
MaheshRavishankar
added a commit
to MaheshRavishankar/iree
that referenced
this pull request
Feb 6, 2025
…zontal fusion changes. This commit is mirror of iree-org#19876 Signed-off-by: MaheshRavishankar <[email protected]>
MaheshRavishankar
force-pushed
the
noconcat_horizontal_fusion_dispatch_region
branch
2 times, most recently
from
0f9bd38 to
cedc3d5
Compare
Max191
pushed a commit
that referenced
this pull request
Feb 10, 2025
…zontal fusion changes. This commit is mirror of #19876 Signed-off-by: MaheshRavishankar <[email protected]>
…zontal fusion changes. Signed-off-by: MaheshRavishankar <[email protected]>
Signed-off-by: MaheshRavishankar <[email protected]>
Signed-off-by: MaheshRavishankar <[email protected]>
Signed-off-by: MaheshRavishankar <[email protected]>
Signed-off-by: Ian Wood <[email protected]>
Signed-off-by: MaheshRavishankar <[email protected]>
Signed-off-by: MaheshRavishankar <[email protected]>
Signed-off-by: MaheshRavishankar <[email protected]>
MaheshRavishankar
force-pushed
the
noconcat_horizontal_fusion_dispatch_region
branch
from
cedc3d5 to
e92f8aa
Compare
IanWood1
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Looks good!
For future reference, this dispatch is the one that was causing issues. All the elementwise multiplications are multiplying different pre-mul weights.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current dispatch region formation handles consumer fusion by making the consumer the root of the DAG moved into dispatches. For cases where we have more than one consumer that dont have a direct dependency, this approach does not work. This changes dispatch region formation to keep the root operation as is, and move in consumers into the dispatch iteratively. This required a few additional changes
moveOperandDefsinto a utility function.flow.dispatch.regioncreated are resolved.