Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Encoding] Implement sizeof for pad encoding layout attr #19890

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

kuhar
Copy link
Member

@kuhar kuhar commented Feb 3, 2025

This is stacked on top of #19865, please review the newest commit only.
Rebased.

@kuhar kuhar force-pushed the pad-encoding-sizeof branch from 25664ca to 4947af7 Compare February 3, 2025 20:57
Copy link
Contributor

@hanhanW hanhanW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, just two questions.

Signed-off-by: Jakub Kuderski <[email protected]>
@kuhar kuhar requested a review from hanhanW February 4, 2025 16:51
@kuhar kuhar enabled auto-merge (squash) February 4, 2025 17:25
@kuhar kuhar merged commit 82255c7 into iree-org:main Feb 4, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants