New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Date and Time pickers for better text input experience. #580

Open

rabbitism wants to merge 5 commits into main from commitinput

Member

rabbitism commented Feb 19, 2025 •

edited

Loading

Before this PR, DatePicker/DateRangePicker/TimePicker/TimeRangePicker/DateTimePicker text editing experience is just horrible.

This PR resolves multiple issues:

Make all controls focusable to improve a11y.
Editing text follows the rule:
- While editing, picker tries to parse text and update corresponding DateTime value. if text is valid, value is updated, if text is not valid, value remains, and text remains.
- When user press Enter or picker lost focus, parse text and update corresponding value. if text is not valid, text will be cleared.
Fix TimeRangePicker ClearButton style issue.

rabbitism added 5 commits

February 19, 2025 21:35


          feat: make text editable.


          feat: add demo, fix clear button of TimeRangePicker.

fa5c9d1


          feat: add menu tag.

d6b50ce


          fix: fix a ut after behavior change.

fa86d34


          misc: fix a minor issue in demo.

862baea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet