Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #117

Conversation

mauropasse
Copy link
Collaborator

Fixes

@mauropasse mauropasse closed this Sep 13, 2023
@mauropasse
Copy link
Collaborator Author

Closed since similar to what discussed in ros2#2218 (comment) :

"...The problem is a race condition and I think that the already existing executor->is_spinning() method is the correct way to synchronize and avoid it."

By means of the same approach, the issues I found are gone.

I opened a PR for the only fix that I think it must still be included: #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant