-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate character_map / UnicodeEncodeError paths with delete operation feature #261
Comments
I think we need to do this sooner rather than later. Syncing with a delete mode defined results in data at translated (read: character-mapped or UnicodeDecodeError-handled) paths getting deleted unexpectedly. |
Hmm, can That doesn't really help with the |
Right. The options I discussed with @korydraughn were...
We wanted 2 to be easy, but I don't think it will be much less effort than 1. 3 is indefensible given the high risk of data loss. |
That assessment seems correct to me. |
Let's give it a try and implement option 1. |
After I started implementing this, I found that option 2 was actually quite easy. We are just going to do that and kick this back to 0.7.0. Sorry for turbulence. |
Whenever a path will be modified due to UnicodeEncodeError handling or a character_map event handler method is defined, the Delete Mode feature should be disabled to prevent data loss. Support for these combinations of features will be implemented in the future.
Whenever a path will be modified due to UnicodeEncodeError handling or a character_map event handler method is defined, the Delete Mode feature should be disabled to prevent data loss. Support for these combinations of features will be implemented in the future.
Requires #48 to be completed first.
The text was updated successfully, but these errors were encountered: