Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate character_map / UnicodeEncodeError paths with delete operation feature #261

Open
alanking opened this issue Sep 11, 2024 · 6 comments
Labels
enhancement New feature or request
Milestone

Comments

@alanking
Copy link
Collaborator

Requires #48 to be completed first.

@alanking
Copy link
Collaborator Author

I think we need to do this sooner rather than later. Syncing with a delete mode defined results in data at translated (read: character-mapped or UnicodeDecodeError-handled) paths getting deleted unexpectedly.

@alanking alanking modified the milestones: 0.7.0, 0.6.0 Oct 10, 2024
@trel
Copy link
Member

trel commented Oct 10, 2024

Hmm, can character_map and delete be detected and declared incompatible?

That doesn't really help with the UnicodeDecodeError cases...

@alanking
Copy link
Collaborator Author

Right. The options I discussed with @korydraughn were...

  1. Just implement the support (Integrate character_map / UnicodeEncodeError paths with delete operation feature #261, this issue). This will take some effort.
  2. Detect and prevent. This is easy enough for character_map. From what I can tell, the amount of effort to do this for the UnicodeEncodeError case would be high enough that we might as well just implement the support.
  3. Punt. Delete Mode is a new feature and we are still pre-1.0, so "Use at your own risk."

We wanted 2 to be easy, but I don't think it will be much less effort than 1. 3 is indefensible given the high risk of data loss.

@trel
Copy link
Member

trel commented Oct 10, 2024

That assessment seems correct to me.

@korydraughn
Copy link
Contributor

Let's give it a try and implement option 1.

@alanking
Copy link
Collaborator Author

After I started implementing this, I found that option 2 was actually quite easy. We are just going to do that and kick this back to 0.7.0. Sorry for turbulence.

@alanking alanking modified the milestones: 0.6.0, 0.7.0 Oct 10, 2024
alanking added a commit to alanking/irods_capability_automated_ingest that referenced this issue Oct 10, 2024
Whenever a path will be modified due to UnicodeEncodeError
handling or a character_map event handler method is defined,
the Delete Mode feature should be disabled to prevent data
loss. Support for these combinations of features will be
implemented in the future.
alanking added a commit that referenced this issue Oct 10, 2024
Whenever a path will be modified due to UnicodeEncodeError
handling or a character_map event handler method is defined,
the Delete Mode feature should be disabled to prevent data
loss. Support for these combinations of features will be
implemented in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants