Add Delete Mode #283
Add Delete Mode #283
Conversation
|
the 'two' tests you mention above... have the same name. |
|
Ah... fixed now. Thanks |
|
I think I've fixed the occasionally failing tests. It seems that it had something to do with the queues the workers are listening to. The spurious failures are gone now. |
|
looking good. |
|
Spurious failures turns out to not have been fixed, but now are fixed. It had to do with the order of operations of removing the parent collection after removing data objects. Removing a subcollection needs to also try to remove its own parent collection as long as it's empty and not the root target collection. I also fixed the /tmp mount directory on the host used by the old test suite because it made me angry. I think this is officially ready for review. |
|
i'm happy with it if all the things are behaving. |
|
If the tests are passing, squash to taste. |
|
Tests are passing. Squashed. |
This commit renames the filesystem_sync and s3_bucket_sync task modules to filesystem_tasks and s3_bucket_tasks. The Celery application and sync script utilities have been updated accordingly.
This will act as a sort of requirements document.
This commit adds a base set of tests for the Delete Mode feature. The tests exercise basic functionality and interactions between the Operations and Delete Modes. This adds a new test file, so the ingest-test Docker instructions have been updated. The ingest-test project now runs both test suites.
This commit adds a new set of tasks to the Automated Ingest Celery application. It also affords two new Events - data_obj_delete and coll_delete. This comes with its own event handlers. The Delete Mode can be set with a new event handler method named delete_mode which returns a member of a new enum in utils named DeleteMode.
This removes the /tmp/mountdir Docker volume mount on the host machine.
|
#'d. Mergin |
Addresses #48
Addresses #235
Addresses #281
I'm okay with squashing commits, but I tried to break them up into logical pieces. Not sure how successful that was.
Old tests are passing.
New tests are passing... almost. There are a couple of things to note about the new tests:
test_PUT_APPEND_and_TRASH_deletes_collectionsandtest_PUT_SYNC_and_TRASH_deletes_collections. The other tests pass consistently, so I think it has to do with the TRASH delete mode. I'll be investigating this.There's no Delete Mode for S3 buckets yet. See #282.