Add ASAN support and fix memleaks (4-3-stable) #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test suite passed |
|
very good. |
korydraughn
reviewed
Dec 19, 2024
|
Tests still passing |
|
what is clang-format requesting? just indentation? |
|
Yes, but a strange thing happens where it will never be satisfied until the whole file is formatted. If I run We can run clang-format on the whole codebase if desired, but I've just been ignoring it until we do that. |
|
ah, i remember that. please ignore. |
Based on the --debug_build option in the build hook in the main iRODS repository.
Requires irods-dev, irods-runtime, and irods-server packages built with ASAN enabled. Also adds an option to the build hook to enable ASAN from the development environment.
|
#'d. In it goes... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #286
Addresses #287
Addresses #288
Need to run test suite, but basic things like tiering out and restaging seem to be working.