-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preliminary Dockerfiles for Rocky Linux 9 and Debian 12 #90
Conversation
69e6f08
to
8042ccc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem good.
Given all the files are new except one, we can wait until externals supports the new platforms before merging.
8042ccc
to
758f9de
Compare
Given that I currently have the externals stuff commented out, I'll switch the PR to draft status until we've got packages in the repos |
The packages for Rocky Linux 9 and Debian 12 externals are now published to packages.irods.org, so I think we are ready to proceed here. |
758f9de
to
b0136e4
Compare
I've updated the PR with the new externals repo option and to add the package repos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks normal.
Let's wait for one more approval before pounding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too much of a stickler for keeping these clean but was curious about the commented-out CMake/PATH lines in the core builders.
Oh, consider linking to irods/irods#7191 and irods/irods#7266 |
b0136e4
to
4f1595a
Compare
4f1595a
to
0fd2d9e
Compare
We don't have externals in our repos for these distros yet, so those parts of the Dockerfiles are commented out.
Some other things worth noting:
powertools
repo is now thecrb
repo. Supposedly this is how it's always been on RHEL proper.--break-system-packages
must be passed topip install