Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preliminary Dockerfiles for Rocky Linux 9 and Debian 12 #90

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

SwooshyCueb
Copy link
Member

We don't have externals in our repos for these distros yet, so those parts of the Dockerfiles are commented out.

Some other things worth noting:

  • In Rocky Linux 9, the powertools repo is now the crb repo. Supposedly this is how it's always been on RHEL proper.
  • The default GCC in Debian 12 is GCC 12.
  • In order to install pip packages globally on Debian 12, the argument --break-system-packages must be passed to pip install
  • xmlrunner is provided in the package repositories for Debian 12

@SwooshyCueb SwooshyCueb force-pushed the newplat.main branch 2 times, most recently from 69e6f08 to 8042ccc Compare July 24, 2023 18:03
Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem good.

Given all the files are new except one, we can wait until externals supports the new platforms before merging.

@SwooshyCueb
Copy link
Member Author

we can wait until externals supports the new platforms before merging

Given that I currently have the externals stuff commented out, I'll switch the PR to draft status until we've got packages in the repos

@SwooshyCueb SwooshyCueb marked this pull request as draft August 22, 2023 17:37
@alanking
Copy link
Contributor

The packages for Rocky Linux 9 and Debian 12 externals are now published to packages.irods.org, so I think we are ready to proceed here.

@SwooshyCueb SwooshyCueb marked this pull request as ready for review September 20, 2023 15:46
@SwooshyCueb
Copy link
Member Author

I've updated the PR with the new externals repo option and to add the package repos

Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks normal.

Let's wait for one more approval before pounding.

externals_builder.rocky9.Dockerfile Show resolved Hide resolved
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too much of a stickler for keeping these clean but was curious about the commented-out CMake/PATH lines in the core builders.

irods_core_builder.debian12.Dockerfile Outdated Show resolved Hide resolved
irods_core_builder.rocky9.Dockerfile Outdated Show resolved Hide resolved
@alanking
Copy link
Contributor

Oh, consider linking to irods/irods#7191 and irods/irods#7266

@alanking alanking merged commit 146e046 into irods:main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants