No std #74
Draft
No std #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowparks
force-pushed
the
no-std
branch
3 times, most recently
from
5e87386 to
93a6030
Compare
allows us to display error details in ironfish repo enables std for reddsa dependency if std is enabled
brings back DecryptionError and EncryptionError type enums adds string parameter back to InvalidInput, restores prior error message, and adds error messages when std and string formatting not available
…-fmt adds error formatting for IronfishFrostError if std is enabled
we recently made changes to the 'multienc' module that changed the structure of encrypted data since it's possible that users have exported multisig accounts encrypted using the old legacy encryption methods we need to support decryption of that data adds MultiRecipientBlob back into the multienc module behind the std feature and defines 'decrypt_legacy' for use decrypting these blobs
adds decrypt_legacy to decrypt data from previous version
hughy
reviewed
Sep 12, 2024
| siphasher = { version = "1.0.0", optional = true } | ||
| x25519-dalek = { version = "2.0.0", features = ["reusable_secrets", "static_secrets"] } | ||
| rand_core = { version = "0.6.4", default-features = false, features = ["alloc"] } | ||
| reddsa = { git = "https://github.com/ZcashFoundation/reddsa.git", rev="9ac52c5c60e454b0032d78a22c05fb79aae1d51e", features = ["frost"], default-features = false } |
There was a problem hiding this comment.
We should change the commit here to ZcashFoundation/reddsa@e113475, which merged the feature into main
| @@ -153,7 +163,8 @@ pub fn import_secret_package( | |||
| exported: &[u8], | |||
| secret: &participant::Secret, | |||
| ) -> Result<SecretPackage, IronfishFrostError> { | |||
| let serialized = multienc::decrypt(secret, exported).map_err(io::Error::other)?; | |||
| let serialized = | |||
There was a problem hiding this comment.
this is just restoring the error type back to what it was before #73
| use rand_core::CryptoRng; | ||
| use rand_core::RngCore; | ||
| use std::borrow::Borrow; | ||
| // use log::info; |
| @@ -53,7 +57,7 @@ mod io { | |||
| } | |||
| } | |||
|
|
|||
| pub type Result<T> = core::result::Result<T, Error>; | |||
| pub(crate) type Result<T> = core::result::Result<T, Error>; | |||
There was a problem hiding this comment.
Tried to revert this and the answer is yes - linter complains about it being an unreachable pub item
| where | ||
| R: io::Read, | ||
| R: crate::io::Read, |
| @@ -74,6 +78,13 @@ mod io { | |||
| Err(Error) | |||
| } | |||
| } | |||
|
|
|||
| fn by_ref(&mut self) -> &mut Self | |||
mat-if
approved these changes
Sep 12, 2024
|
|
||
| [dev-dependencies] | ||
| hex-literal = "0.4.1" | ||
| rand = "0.8.5" | ||
|
|
||
| [features] | ||
| default = ["std", "signing"] | ||
| default = ["dkg", "std"] |
There was a problem hiding this comment.
Should the default include all 3 (add signing)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
no-stdcompatibility to ironfish frost.TODO:
Currently targeted to ironfish fork of reddsa waiting for this PR to merge:
ZcashFoundation/reddsa#166