Update the blockchain db whenever a mint with transferOwnershipTo is seen
#4253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -91,4 +91,13 @@ export class Assert { | |||
| throw new Error(`We must have forgotten a falsey value: ${String(x)}`) | |||
| } | |||
| } | |||
|
|
|||
| static bufferEquals(x: Buffer, y: Buffer, message?: string): void { | |||
There was a problem hiding this comment.
I looked around if a similar function already exists but couldn't find any. I wouldn't be surprised though if there's already something similar
mat-if
approved these changes
Aug 28, 2023
andreacorbellini
force-pushed
the
asset-security
branch
from
5a6b229 to
44fc998
Compare
…s seen When a `MintDescription` with `transferOwnershipTo` is seen, the relevant asset on the chain db is updated to reflect the new owner.
andreacorbellini
deleted the
andrea/ifl-1467-update-chain-db-when-a-mint-with-transferownershipto-is
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a
MintDescriptionwithtransferOwnershipTois seen, the relevant asset on the chain db is updated to reflect the new owner.Testing Plan
Unit tests. Once the RPC changes are in place, manual testing will be performed as well.
Documentation
No doc change required
Breaking Change
Not a breaking change