Adding hex flag to handle invalid hex field #4325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-if
approved these changes
Oct 5, 2023
ironfish-cli/src/flags.ts
Outdated
| parse: async (input, _ctx, opts) => { | ||
| const hexRegex = /^[0-9A-Fa-f]+$/g | ||
| if (!hexRegex.test(input)) { | ||
| throw new Error(`The hex string is invalid for field ${opts.name}`) |
There was a problem hiding this comment.
Thinking about this error message a bit. I wonder if something like "The value provided for ${opts.name} is an invalid format. The value must only contain numbers and letters A-F" or something. I wouldn't want the expectation that a user should know or care what hex is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: IFL-1714
https://linear.app/if-labs/issue/IFL-1714/cli-crashes-with-assetid-flag
Result (on Testnet)
Invalid hex value for asset id:
Valid hex value:
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.