chore(IFL-1355): removes reference to transmission key #4420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowparks
force-pushed
the
chore-cleanup-transmission-key
branch
2 times, most recently
from
e1a3b34 to
d02fe5b
Compare
jowparks
force-pushed
the
chore-cleanup-transmission-key
branch
from
d02fe5b to
4adcc9b
Compare
jowparks
changed the title
mat-if
approved these changes
Nov 6, 2023
jowparks
force-pushed
the
chore-cleanup-transmission-key
branch
2 times, most recently
from
39aedac to
dbe8d14
Compare
jowparks
force-pushed
the
chore-cleanup-transmission-key
branch
from
dbe8d14 to
decc425
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We do not use a diversifier in ironfish. This decision was made to allow auditability of fund sources when someone is receiving funds and uses their incoming view key to decrypt incoming funds.
Because of this transparency of sender, there is no longer a concept of a transmission key, which was an opaque version of the public address. This changes removes the vestigial naming.
Testing Plan
Tests pass
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.