STAGING -> MASTER #4466
Merged
STAGING -> MASTER #4466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only used by the standalone wallet and should not be referenced in the CLI.
This fixes the issue if you mount 2 TLS adapters, they'll race to generate 2 auth. Also each adapter that needs token would have to generate it.
This reduces the need for a full node for the Migrator dependencies. It allows anyone to run migrations that can satisify the migrator context requirements.
* Adding index column and sorting by state * adding command * removing sort exclusive flag * removing index column * replacing flags with default ux table flags
When trying to maintain the max peer count allowed, the peer connection manager should not disconnect whitelisted nodes. The expectation for whitelisted nodes is that they should essentially be treated special and assumed to always be connected.
* changing order of connections * Only connecting to bootstrap nodes when no web socket peers exist * splitting out websocker server to function * Adding comments: * changing order: * Update ironfish/src/network/peerNetwork.ts Co-authored-by: mat-if <[email protected]> --------- Co-authored-by: mat-if <[email protected]>
* Fix an RPC timing attack This fixes a timing attack where the comparater for strings is not constant time. You can find the password over time by trying different bytes which allow you to get closer and closer to the actual password. See https://en.wikipedia.org/wiki/Timing_attack * Fix issue with function exception * ADd true constant time * PR feedback * fix failing test * Fix config change listener
service commands have moved to the ironfish-services-cli repo
* removes service commands from ironfish-cli service commands have moved to the ironfish-services-cli repo * removes WebApi from sdk removing the service commands from ironfish-cli removes all but two of the WebApi methods in the sdk: a method for submitting telemetry and a method to support the 'faucet/getFunds' RPC moving the logic for these methods out to their clients allows us to remove the WebApi module altogether removing the WebApi module decouples the faucet api from the telemetry api * fixes getFunds test
* nullifier and note hash are together * changing spent from checkmark to true and false * changing false to x
I got confused when I looked in this file in the RPC folder, and these are not types for the RPC Layer, but types for individual routes. They should not live in the RPC code because it's conflating a system, with things that consume that system.
trimming the account name makes any account with leading or trailing whitespace unusable with the cli we don't trim whitespace in the rpc or sdk when creating accounts, so it's possible for users to have accounts that have leading or trailing whitespace
This allows us to isolate the requirements down to what each route needs. This is a form of dependency injection where the route needs to satisfy it's own dependencies, rather than have a DI system do this. A DI system would be fine too, I just didn't want to pull one into the code base..
* Remove WalletNode from SDK This is now moved entirely into the standalone CLI codebase. * Fixed broken util
These config options are only used by an external repository and should not be added to the SDK config itself.
* adding ability to select notes in the transaction send command * change notes to note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.