feat: add unsigned transaction, unsigned mint, unsigned spend serde #4522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowparks
force-pushed
the
create-unsigned-transaction
branch
6 times, most recently
from
e14cd12 to
7decc7e
Compare
jowparks
force-pushed
the
create-unsigned-transaction
branch
from
7decc7e to
d58daeb
Compare
jowparks
changed the title
patnir
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
UnsignedTransactionstructure boilerplate.This will be used in Frost multisig, the unsigned transaction will be propagated to the participants for partial signing of mints/spends, which the coordinator will then accumulate into a finalized signature.
Testing Plan
Currently there is no construction of this object, I will add a test when we add the
buildmethod on theProposedTransactionwhich will generate anUnsignedTransaction.Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.