repeat long prompt for account import
#4721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patnir
commented
Feb 13, 2024
ironfish-cli/src/utils/longPrompt.ts
Outdated
Comment on lines
27
to
34
| let userInput = (await fetchResponse(question)).trim() | ||
|
|
||
| while (userInput.length === 0 && options?.required) { | ||
| userInput = (await fetchResponse(question)).trim() | ||
| } | ||
|
|
||
| return userInput | ||
| } |
There was a problem hiding this comment.
we'll need this pattern of re-prompting the user when they enter an empty string in multiple places
patnir
changed the title
repeat long prompt for account import
patnir
force-pushed
the
rahul/longPromptForAccountImport
branch
from
9bbe6a3 to
4b50b82
Compare
This was referenced Feb 13, 2024
jowparks
reviewed
Feb 13, 2024
| @@ -4,7 +4,7 @@ | |||
| import readline from 'readline' | |||
|
|
|||
| // Most effective way to take in a large textual prompt input without affecting UX | |||
There was a problem hiding this comment.
Instead of separate methods here, lets just use recursion.
patnir
commented
Feb 13, 2024
ironfish-cli/src/utils/longPrompt.ts
Outdated
Comment on lines
35
to
38
| const rl = readline.createInterface({ | ||
| input: process.stdin, | ||
| output: process.stdout, | ||
| }) |
There was a problem hiding this comment.
jowparks
force-pushed
the
rahul/longPromptForAccountImport
branch
2 times, most recently
from
1f0aeb3 to
9df58a7
Compare
jowparks
approved these changes
Feb 13, 2024
jowparks
force-pushed
the
rahul/longPromptForAccountImport
branch
from
9df58a7 to
87e3495
Compare
jowparks
force-pushed
the
rahul/longPromptForAccountImport
branch
from
87e3495 to
d05925f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes the long prompt UX to repeat the prompt if the user passes an empty string/ no value.
Changes account import to use this helper function
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.