automatically rejoins session when reconnecting to server #5563
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
if a client disconnects from the multisig broker server unexpectedly then the server will remove the client and its identity from the session
client automatically rejoins the session after automatically reconnecting so that the server adds it and its identity back into the session
nests sessionId and passphrase properties into a single 'session' property along with the identity. sessionId, passphrase, and identity must all be non-null or all null, and grouping them into an object reflects this
Testing Plan
apply the diff below (
git diff apply
) to make the server drop a client's connection on ~50% of 'dkg.get_status' messages:run
wallet:multisig:dkg:create
with two participants, and the process should still complete (eventually) with clients reconnectingDocumentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpc
orbreaking-change-sdk
.