dont cache yarn #5584
Merged
dont cache yarn #5584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The performance test CI job was regularly taking ~45 minutes, with it sometimes taking up to an hour and a half. The reason it takes more than 10 minutes at all is because it is downloading a 7.5gb yarn cache via the
actions/setup-nodejob. This is unnecessary since it seems to have all of these files cached locally as it is.After removing the yarn cache, it has to recompile the rust code on each run. However, since the runner is a fairly powerful machine, it only takes about a minute, which seems better than trying to download the cache from a data center somewhere over a somewhat slow wifi network.
See: https://github.com/iron-fish/ironfish/actions/runs/11523779611/job/32082513578
Testing Plan
Ran the perf job directly on the branch by adding it to the job's push branches and allowing the runner to run on this branch. https://github.com/iron-fish/ironfish/actions/runs/11523779611/job/32082513578
Documentation
N/A
Breaking Change
N/A