Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure artifacts folder exists when deploying rust bindings #5588

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

mat-if
Copy link
Contributor

@mat-if mat-if commented Oct 25, 2024

Summary

When deploying the rust binding packages, if the download-artifacts step fails to download any artifacts, it will not raise an error. Neither will the npm publish step. This will lead to problems where the packages depending on the bindings will be broken since the bindings will not get released.

This PR adds a basic sanity check to make sure that some artifacts are downloaded, otherwise it will fail.

Closes IFL-2719

Testing Plan

Temporarily added this step into a different CI job to ensure it works as expected.

Documentation

N/A

Breaking Change

N/A

@mat-if mat-if requested a review from a team as a code owner October 25, 2024 22:45
@mat-if mat-if merged commit 7513b1a into staging Oct 25, 2024
13 checks passed
@mat-if mat-if deleted the mat/ensure-artifacts-exist branch October 25, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants